Skip to content

feat(event_sources): add support for VPC Lattice events #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 8, 2023
Merged

feat(event_sources): add support for VPC Lattice events #2358

merged 17 commits into from
Jun 8, 2023

Conversation

stephenbawks
Copy link
Contributor

@stephenbawks stephenbawks commented Jun 1, 2023 •
edited by leandrodamascena
Loading

Issue number: 2359

Summary

I'm excited that VPC Lattice has finally been released and I'm looking forward to integrating it into PowerTools. It's a significant development, so I am adding a new data class to manage the event flow from VPC Lattice to Lambda.

Changes

Added a new VPCLatticeEvent data class.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@stephenbawks stephenbawks requested a review from a team as a code owner June 1, 2023 10:46
@stephenbawks stephenbawks requested review from leandrodamascena and removed request for a team June 1, 2023 10:46
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 1, 2023
@stephenbawks stephenbawks changed the title VPC Lattice Event VPC Lattice Event - Work in Progress Jun 1, 2023
@stephenbawks stephenbawks marked this pull request as draft June 1, 2023 10:46
@boring-cyborg boring-cyborg bot added the tests label Jun 1, 2023
@stephenbawks stephenbawks changed the title VPC Lattice Event - Work in Progress feat(data_classes): Adding VPC Event Type Jun 1, 2023
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jun 1, 2023
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2023
@stephenbawks stephenbawks marked this pull request as ready for review June 1, 2023 16:23
@stephenbawks stephenbawks changed the title feat(data_classes): Adding VPC Event Type feat(data_classes): Adding VPC Lattice Event Type Jun 1, 2023
@leandrodamascena leandrodamascena linked an issue Jun 1, 2023 that may be closed by this pull request
Feature request: Add Data Class to handle VPC Lattice Event type #2359
Closed
2 tasks
@leandrodamascena leandrodamascena changed the title feat(data_classes): Adding VPC Lattice Event Type feat(event_sources): add support for VPC Lattice events Jun 1, 2023
@github-actions github-actions bot added the feature New feature or functionality label Jun 1, 2023
@leandrodamascena
Copy link
Contributor

leandrodamascena commented Jun 1, 2023 •
edited
Loading

Hi @stephenbawks! Adding support for VPC Lattice events is really awesome because it's in GA and customers are adopting it.

We are going to release a version tomorrow and we don't have more time to include this PR in this version, but we will work to merge it next week and include it in the next release, ok?

Thank you so much for sending this PR and putting effort to make it happens! BTW, I loved the documentation update! ❤️

@leandrodamascena
Copy link
Contributor

Adding "do-not -merge" label just to avoid merging before we release a new version.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 74.35% and project coverage change: -0.13 ⚠️

Comparison is base (824912b) 97.18% compared to head (9cf1ddc) 97.06%.

❗ Current head 9cf1ddc differs from pull request most recent head 0c208f2. Consider uploading reports for the commit 0c208f2 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2358      +/-   ##
===========================================
- Coverage    97.18%   97.06%   -0.13%     
===========================================
  Files          153      154       +1     
  Lines         7008     7047      +39     
  Branches       513      515       +2     
===========================================
+ Hits          6811     6840      +29     
- Misses         156      166      +10     
  Partials        41       41
Impacted Files Coverage Δ
...a_powertools/utilities/data_classes/vpc_lattice.py 73.68% <73.68%> (ø)
...mbda_powertools/utilities/data_classes/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

leandrodamascena
leandrodamascena requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stephenbawks! I only made one comment before merging it.

I tested it with VPC Lattice + Lambda and it's working perfectly! Thank you very much for this incredible work.

@stephenbawks
Copy link
Contributor Author

Hi @stephenbawks! I only made one comment before merging it.

I tested it with VPC Lattice + Lambda and it's working perfectly! Thank you very much for this incredible work.

Awesome. I will get started on the resolver/handler next.

@leandrodamascena leandrodamascena self-requested a review June 8, 2023 12:44
leandrodamascena
leandrodamascena approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for addressing all the comments and working hard to merge them, @stephenbawks!
APPROVED!

@leandrodamascena leandrodamascena merged commit ad6a85b into aws-powertools:develop Jun 8, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 8, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

sthulb pushed a commit that referenced this pull request Jun 19, 2023
@stephenbawks @leandrodamascena
@heitorlessa @sthulb
feat(event_sources): add support for VPC Lattice events (#2358)
e416e1e 
Co-authored-by: Leandro Damascena <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa left review comments

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation feature New feature or functionality size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Add Data Class to handle VPC Lattice Event type
4 participants
@stephenbawks @leandrodamascena @codecov-commenter @heitorlessa